fix: handle BASH_REMATCH syntax in command validation to prevent crashes #5979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add specific handling for BASH_REMATCH array syntax in parseCommand
- Handle both ${BASH_REMATCH[n]} and $BASH_REMATCH[n] patterns
- Add comprehensive test cases for BASH_REMATCH parsing
- Fixes issue #5978 where gh alias commands with BASH_REMATCH caused crashes
dosubot
bot
added
size:M
hannesrudolph
added
the
Issue/PR - Triage
Member
|
Already solved by #5743 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #5978 where command validation crashes when parsing BASH_REMATCH in gh alias commands.
Problem
The command validation system was throwing a "Bad substitution: BASH_REM" error when encountering BASH_REMATCH array syntax in shell commands, causing the application to crash.
Solution
parseCommandfunction${BASH_REMATCH[n]}and$BASH_REMATCH[n]patternsTesting
Fixes #5978
Important
Fixes crash in
parseCommandby handling BASH_REMATCH syntax, with tests added to verify the solution.parseCommandincommand-validation.tswhen encountering BASH_REMATCH syntax.${BASH_REMATCH[n]}and$BASH_REMATCH[n]by replacing them temporarily during parsing.command-validation.spec.tsto verify BASH_REMATCH handling.This description was created by
for ff0ad63. You can customize this summary. It will automatically update as commits are pushed.